Re: [PATCH] Kprobes /proc entry

[Stephen Hemminger <shemminger@xxxxxxxx>]

The module ref counting should be done by the VFS layer
not the interface. See below:

> - --- ./kernel/kprobes.c	2005-01-13 20:41:11.000000000 +0100
> +++ ./kernel/kprobes.c	2005-01-13 20:39:27.000000000 +0100
> @@ -33,6 +33,9 @@
>  #include <linux/hash.h>
>  #include <linux/init.h>
>  #include <linux/module.h>
> +#include <linux/fs.h>
> +#include <linux/debugfs.h>
> +#include <linux/kallsyms.h>
>  #include <asm/cacheflush.h>
>  #include <asm/errno.h>
>  #include <asm/kdebug.h>
> @@ -131,6 +134,96 @@
>  	unregister_kprobe(&jp->kp);
>  }
> 
> +#ifdef CONFIG_DEBUG_FS
> +int kprobes_open(struct inode *inode, struct file *file)
> +{
> +	try_module_get(THIS_MODULE);
not needed (see below).
> +	return 0;
> +}
> +
> +int kprobes_release(struct inode *inode, struct file *file)
> +{
> +	module_put(THIS_MODULE);
ditto

> +	return 0;
> +}

> +
> +struct dentry *kprobes_dir, *kprobes_list;
> +struct file_operations kprobes_fops = {
> +	.open = kprobes_open,
> +	.read = kprobes_read,
> +	.release = kprobes_release
Add:
	.owner = THIS_MODULE,

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/