Re: [PATCH 167] Kill unused variables in the net code

[linux-os <linux-os@xxxxxxxxxxxxxxxxxx>]

On Fri, 7 Jan 2005, Geert Uytterhoeven wrote:

> 2.4.28-rc2 introduced a warning in the net code on non-SMP:
>
>    net/core/neighbour.c:1809: warning: unused variable `tbl'
>
> The following patch fixes this.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>
> --- linux-2.4.29-rc1/include/linux/spinlock.h	2004-04-27 17:22:10.000000000 +0200
> +++ linux-m68k-2.4.29-rc1/include/linux/spinlock.h	2005-01-07 21:51:28.000000000 +0100
> @@ -147,7 +147,7 @@
>
> #define rwlock_init(lock)	do { } while(0)
> #define read_lock(lock)	(void)(lock) /* Not "unused variable". */
> -#define read_unlock(lock)	do { } while(0)
> +#define read_unlock(lock)	(void)(lock) /* Not "unused variable". */
> #define write_lock(lock)	(void)(lock) /* Not "unused variable". */
> #define write_unlock(lock)	do { } while(0)
>
>
> Gr{oetje,eeting}s,
>
> 						Geert


But don't all you need to do is:

#define read_unlock(x)





Cheers,
Dick Johnson
Penguin : Linux version 2.6.10 on an i686 machine (5537.79 BogoMips).
 Notice : All mail here is now cached for review by Dictator Bush.
                 98.36% of all statistics are fiction.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/