[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] per thread page reservation patch
Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:
>> diff -puN include/linux/gfp.h~reiser4-perthread-pages include/linux/gfp.h
>> --- linux-2.6.10-rc3/include/linux/gfp.h~reiser4-perthread-pages 2004-12-22 20:09:44.153164276 +0300
[...]
>
>> +int perthread_pages_count(void)
>> +{
>> + return current->private_pages_count;
>> +}
>> +EXPORT_SYMBOL(perthread_pages_count);
>
> Again a completely useless wrapper.
I disagree. Patch introduces explicit API
int perthread_pages_reserve(int nrpages, int gfp);
void perthread_pages_release(int nrpages);
int perthread_pages_count(void);
sufficient to create and use per-thread reservations. Using
current->private_pages_count directly
- makes API less uniform, not contained within single namespace
(perthread_pages_*), and worse,
- exhibits internal implementation detail to the user.
>
[...]
Nikita.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Follow-Ups:
References: