[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: From last __GFP_ZERO changes
On Thu, Jan 06, 2005 at 12:43:58PM +0100, Marco Cipullo wrote:
> From last __GFP_ZERO changes:
>
> --- a/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
> +++ b/drivers/block/pktcdvd.c 2005-01-06 03:27:45 -08:00
> @@ -135,12 +135,10 @@
> goto no_bio;
>
> for (i = 0; i < PAGES_PER_PACKET; i++) {
> - pkt->pages[i] = alloc_page(GFP_KERNEL);
> + pkt->pages[i] = alloc_page(GFP_KERNEL|| __GFP_ZERO);
>
> Is this OK?
>
> Or should be
>
> for (i = 0; i < PAGES_PER_PACKET; i++) {
> - pkt->pages[i] = alloc_page(GFP_KERNEL);
> + pkt->pages[i] = alloc_page(GFP_KERNEL| __GFP_ZERO);
It definitely should be the latter.
CCing Christoph so he can fix this up.
mh
--
Martin Hicks Wild Open Source Inc.
mort@xxxxxxxxxxxxxxxxxx 613-266-2296
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Follow-Ups:
References: