[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ptrace single-stepping change breaks Wine
- From: Daniel Jacobowitz <dan@xxxxxxxxxx>
- Date: Fri, 31 Dec 2004 10:10:45 -0500
- Mail-followup-to: Linus Torvalds <torvalds@xxxxxxxx>, Jesse Allen <the3dfxdude@xxxxxxxxx>, Davide Libenzi <davidel@xxxxxxxxxxxxxxx>, Mike Hearn <mh@xxxxxxxxxxxxxxx>, Thomas Sailer <sailer@xxxxxx>, Eric Pouech <pouech-eric@xxxxxxxxxx>, Roland McGrath <roland@xxxxxxxxxx>, Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, wine-devel <wine-devel@xxxxxxxxxx>
- References: <Pine.LNX.4.58.0412292106400.454@bigblue.dev.mdolabs.com> <Pine.LNX.4.58.0412292256350.22893@ppc970.osdl.org> <Pine.LNX.4.58.0412300953470.2193@bigblue.dev.mdolabs.com> <53046857041230112742acccbe@mail.gmail.com> <Pine.LNX.4.58.0412301130540.22893@ppc970.osdl.org> <Pine.LNX.4.58.0412301436330.22893@ppc970.osdl.org> <20041230230046.GA14843@nevyn.them.org> <Pine.LNX.4.58.0412301513200.22893@ppc970.osdl.org> <20041231053618.GA25850@nevyn.them.org> <Pine.LNX.4.58.0412302141320.2280@ppc970.osdl.org>
- User-agent: Mutt/1.5.5.1+cvs20040105i
On Thu, Dec 30, 2004 at 09:47:42PM -0800, Linus Torvalds wrote:
> So I looked at just sharing the code with the debug trap handler, and the
> result is appended. strace works, as does all the TF tests I've thrown at
> it, and the code actually looks better anyway (the old do_debug code looks
> like it got the EIP wrong in VM86 mode, for example, this just cleans
> that up too). Just use a common "send_sigtrap()" routine.
>
> Does this look saner?
Lots, I like it. The syscall trap will always be delivered before the
single-step trap, right, because signal delivery won't run until we
return to userspace?
--
Daniel Jacobowitz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Follow-Ups: