Re: 2.6.2-mm1, selinux, and initrd

[James Morris <jmorris _at_ xxxxxxxxxx>]

On Sat, 7 Feb 2004 Valdis.Kletnieks _at_ vt.edu wrote:

> On Fri, 06 Feb 2004 22:39:45 EST, James Morris said:
> 
> > Can you please try the patch below against  the 2.6.2-mm1 kernel and let 
> > me know if you still see the problem.
> 
> > diff -urN -X dontdiff linux-2.6.2-mm1.o/fs/super.c linux-2.6.2-mm1.w/fs/super
> .c
> > --- linux-2.6.2-mm1.o/fs/super.c	2004-02-05 09:24:12.000000000 -0500
> > +++ linux-2.6.2-mm1.w/fs/super.c	2004-02-06 22:32:43.309927664 -0500
> > @@ -709,7 +709,6 @@
> >  	struct super_block *sb = ERR_PTR(-ENOMEM);
> >  	struct vfsmount *mnt;
> >  	int error;
> > -	char *secdata = NULL;
> 
> Yes, backing out that part of the 3 patches that hits fs/super.c makes
> a kernel that boots with selinux enabled.

Ok, looks like a problem where devfs is passing an empty string to 
do_mount when it expects a page.

Please try the patch below against 2.6.2-mm1.


- James
-- 
James Morris
<jmorris _at_ redhat.com>

diff -urN -X dontdiff linux-2.6.2-mm1.o/fs/devfs/base.c linux-2.6.2-mm1.w/fs/devfs/base.c
--- linux-2.6.2-mm1.o/fs/devfs/base.c	2004-02-05 09:24:12.000000000 -0500
+++ linux-2.6.2-mm1.w/fs/devfs/base.c	2004-02-07 08:39:17.000000000 -0500
@@ -2832,7 +2832,7 @@
     int err;
 
     if ( !(boot_options & OPTION_MOUNT) ) return;
-    err = do_mount ("none", "/dev", "devfs", 0, "");
+    err = do_mount ("none", "/dev", "devfs", 0, NULL);
     if (err == 0) printk (KERN_INFO "Mounted devfs on /dev\n");
     else PRINTK ("(): unable to mount devfs, err: %d\n", err);
 }   /*  End Function mount_devfs_fs  */

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo _at_ vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/