Re: [patch] PCI Express Enhanced Config Patch - 2.6.0-test11

[ebiederm _at_ xxxxxxxxxxxx (Eric W. Biederman)]

Matthew Wilcox <willy _at_ debian.org> writes:

> On Thu, Jan 29, 2004 at 08:05:52AM -0800, Linus Torvalds wrote:
> > The compiler _should_ entirely compile away "fix_to_virt(xxx)", so by 
> > creating a variable for the value, you're actually making code generation 
> > worse. You might as well have
> > 
> > 	#define mmcfg_virt_addr (fix_to_virt(FIX_PCIE_MCFG))
> > 
> > instead.
> 
> Ahh, I missed the comment towards the top of fixmap.h that this is a
> constant address.  You're so smart sometimes ;-)
> 
> > That said, this patch looks perfectly acceptable to me. With some testing, 
> > I'd take it through Greg or -mm.
> 
> Cool.  Here's the final version for testing then.

Is it really safe to treat the base address as a u32?  I know
if I was doing the BIOS and that address was tied to a 32bit BAR I
would be extremely tempted to put those 256M of address space above
4G.  Putting something like that below 4G leads to 1/2 Gig of memory
missing. 

You can also put the memory above 4G on most intel chipsets but I'd
rather have my memory down low where my legacy OS could get to it
rather than have my PCI extended configuration space down low where
nothing really needs it. 

Point being I don't think it is safe to assume the BIOS always puts
the extended PCI configuration space below 4G.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo _at_ vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/