Re: [PATCH] PC300 update

[Marcelo Tosatti <marcelo.tosatti _at_ xxxxxxxxxxxx>]

Hi Christoph!

On Wed, 28 Jan 2004, Christoph Hellwig wrote:

> > - Mark pci_device_id list with __devinitdata
>
> This is bogus and can crash the kernel if you're unlucky.

Other wan drivers are doing the same:

[marcelo _at_ logos wan]$ grep __devinitdata *
farsync.c:static char *type_strings[] __devinitdata = {
wanxl.c:static struct pci_device_id wanxl_pci_tbl[] __devinitdata = {

I believe a handful of others are using "__devinitdata". How can the
kernel crash because of this? Who will try to touch the data?

> > - Add #ifdef DEBUG around debug printk()
>
> What about dprintk or friends instead?

Yes I will change to dev_dbg() as Greg suggested. Thanks!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo _at_ vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/