> On Tue, Jan 20, 2004 at 12:55:39PM +1100, Rusty Russell wrote: > > Please replace the MODULE_PARM lines with the modern form: > > > > module_param(repeat, bool, 0644); > > module_param(debug, int, 0644); > > I'll do for the bttv ir support, that is 2.6 only anyway due to the > usage of tasklets. Here we go. Gerd ==============================[ cut here ]============================== diff -u linux-2.6.1-mm5/drivers/media/video/ir-kbd-i2c.c linux/drivers/media/video/ir-kbd-i2c.c --- linux-2.6.1-mm5/drivers/media/video/ir-kbd-i2c.c 2004-01-20 12:59:51.491270352 +0100 +++ linux/drivers/media/video/ir-kbd-i2c.c 2004-01-20 13:03:04.982855160 +0100 @@ -25,6 +25,7 @@ */ #include <linux/module.h> +#include <linux/moduleparam.h> #include <linux/init.h> #include <linux/kernel.h> #include <linux/sched.h> @@ -55,8 +56,7 @@ /* ----------------------------------------------------------------------- */ /* insmod parameters */ -static int debug = 0; /* debug level (0,1,2) */ -MODULE_PARM(debug,"i"); +module_param(debug, int, 0644); /* debug level (0,1,2) */ #define DEVNAME "ir-kbd-i2c" #define dprintk(level, fmt, arg...) if (debug >= level) \ diff -u linux-2.6.1-mm5/drivers/media/video/ir-kbd-gpio.c linux/drivers/media/video/ir-kbd-gpio.c --- linux-2.6.1-mm5/drivers/media/video/ir-kbd-gpio.c 2004-01-20 12:59:51.490270504 +0100 +++ linux/drivers/media/video/ir-kbd-gpio.c 2004-01-20 13:03:05.080840264 +0100 @@ -18,6 +18,7 @@ */ #include <linux/module.h> +#include <linux/moduleparam.h> #include <linux/init.h> #include <linux/input.h> #include <linux/delay.h> @@ -170,8 +171,7 @@ struct timer_list timer; }; -static int debug = 0; /* debug level (0,1,2) */ -MODULE_PARM(debug,"i"); +module_param(debug, int, 0644); /* debug level (0,1,2) */ #define DEVNAME "ir-kbd-gpio" #define dprintk(fmt, arg...) if (debug) \ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo _at_ vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
References:
- [patch] v4l-05 add infrared remote supportGerd Knorr
- Re: [patch] v4l-05 add infrared remote supportRusty Russell
- Re: [patch] v4l-05 add infrared remote supportGerd Knorr
- Prev by Date: [patch] -mm5 has no i2c on amd64
- Next by Date: [PATCH] some more fixes for inode.c
- Previous by thread: Re: [patch] v4l-05 add infrared remote support
- Next by thread: Re: [patch] v4l-05 add infrared remote support
- Indexes:[Main][Thread]