Re: cs89x0 in 2.5 (was Re: eepro100 - 802.1q - mtu size)

[Paul P Komkoff Jr <i _at_ xxxxxxxxxx>]

Replying to Jeff Garzik:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/davej/patches/2.5/2.5.48/split-dj1/net-cs89x0-media-corrections.diff
> 
> 
> IIRC it came from -ac tree without explanation, and I think akpm said it
> broke stuff.  Since it has an alive maintainer (akpm), I would rather
> let Alan and Andrew fight it out :)  Whatever they decide is fine with
> me for 2.5.

It is not a magic number in net drivers. I was author of this bit, and
without it I cannot start onboard nic on IBM PC300 GL (a lot of them I
have here). Actually, to _understand_ what this bit do you just need
to look at the driver source and see _how_ it works with
A_CNF_MEDIA_10B_2 constants. More specific, it expects that there are
single bits, and before my patch A_CNF_MEDIA_10B_2 was 0x60. 0x60 is
not a single bit.

I've thought this change is obvious, and as far as I can remember
Andrew has nothing against it.

-- 
Paul P 'Stingray' Komkoff Jr /// (icq)23200764 /// (http)stingr.net
 This message represents the official view of the voices in my head
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo _at_ vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/