On Sun, 2003-01-12 at 17:06, Oliver Neukum wrote: > Please don't do such things. The next time locking is changed and a lock > is needed here, some poor guy has to go through that and change all > back to goto. > This may not be applicable here, but as a general rule, don't do it. > I speak from experience. > > As for efficiency, that is the compiler's job. I say "please don't use goto" and instead have a "cleanup_lock" function and add that before all the return statements.. It should not be a burden. Yes, it's asking the developer to work a little harder, but the end result is better code. -Rob - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo _at_ vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Follow-Ups:
- Re: any chance of 2.6.0-test*?Oliver Neukum
- Re: any chance of 2.6.0-test*?Robert Love
- Re: any chance of 2.6.0-test*?Linus Torvalds
- Re: any chance of 2.6.0-test*?Matti Aarnio
- Re: any chance of 2.6.0-test*?Rob Wilkens
- Re: any chance of 2.6.0-test*?Oliver Neukum
- Prev by Date: Re: any chance of 2.6.0-test*?
- Next by Date: [PATCH 2.5.56-bk2, updated] cpufreq: sysfs interface
- Previous by thread: Re: any chance of 2.6.0-test*?
- Next by thread: Re: any chance of 2.6.0-test*?
- Indexes:[Main][Thread]