Re: Linux 2.4.21-pre3-ac4

[Alan Cox <alan _at_ xxxxxxxxxxxxxxxxxxx>]

On Sun, 2003-01-12 at 19:57, Benjamin Herrenschmidt wrote:
> Actually, do we really need that delay as we are waiting for an
> interrupt anyway ? my understanding is that this delay is the required
> before we start polling for BSY bit (that is the max time the drive may
> take to assert BSY after getting the command), but in our case, unless
> we have other bugs, we shall have the channel marked busy, so nobody
> will tap it, except the actual interrupt coming in. Or will the case of
> shared interrupt potentially cause a read of status at the wrong time ?

Precisely. Or a random IRQ from a drive power change or hotplug that
passed our command in the other direction.

We could actually address this another way which might even be easier, 
that is in the IRQ path to wait the 400nS if BSY isnt asserted. I need
to go reread the spec to check if we can poll it before the timeout
but not trust the data, or cannot poll it.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo _at_ vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/