Re: Compile problem on Alpha

[Keith Owens <kaos _at_ ocs.com.au>]

On Sat, 19 Aug 2000 18:36:23 +0100 (BST), 
Mo McKinlay <mmckinlay _at_ gnu.org> wrote:
>kaos wrote (but McKinlay did not indicate that kaos wrote)
>>
>># Index: 16.1/depmod/depmod.c
>># --- 16.1/depmod/depmod.c Sun, 13 Aug 2000 06:45:56 -0700 kaos (modutils-2.3/b/43_depmod.c 1.19 644)
>># +++ 16.1(w)/depmod/depmod.c Sat, 19 Aug 2000 03:22:33 -0700 kaos (modutils-2.3/b/43_depmod.c 1.19 644)
>
>[Patch snipped]
>
><humble opinion>
>
>Um, shouldn't this be a #define'd limit, not a literal that appears
>multiple times in the source? I know it sounds like I'm nitpicking (well,
>I am kinda, *grin*), but it might help prevent future breakage, and make
>tuning less fraught with danger if it becomes necessary (this case being
>an example).

It should be #defined'd and in modutils 2.3.16 it will be, it will even
be exposed and documented as a configure variable.  This was just a
quick and dirty patch.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo _at_ vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/